Communicate known foreign key violations to the user.
This commit is contained in:
@@ -3,11 +3,11 @@ use std::collections::HashMap;
|
||||
use uuid::Uuid;
|
||||
|
||||
use super::{
|
||||
DecodeError, QueryConversionError, RepositoryError,
|
||||
DecodeError, QueryConversionError, ReferenceRelation, ReferenceViolationKind, RepositoryError,
|
||||
dtos::{Delete, Upsert},
|
||||
};
|
||||
use crate::{
|
||||
database::{accounts as db, dtos::AccountRow},
|
||||
database::{Constraint, DatabaseError, accounts as db, dtos::AccountRow},
|
||||
domain::Account,
|
||||
};
|
||||
|
||||
@@ -109,7 +109,32 @@ pub async fn delete<'e, E>(executor: E, id: Uuid) -> Result<Delete, RepositoryEr
|
||||
where
|
||||
E: sqlx::Executor<'e, Database = sqlx::Postgres>,
|
||||
{
|
||||
Ok(db::delete_by_id(executor, id).await?.into())
|
||||
let deleted = db::delete_by_id(executor, id)
|
||||
.await
|
||||
.map_err(classify_delete_error)?;
|
||||
|
||||
Ok(deleted.into())
|
||||
}
|
||||
|
||||
fn classify_delete_error(error: DatabaseError) -> RepositoryError {
|
||||
let is_recurring_transaction_reference = matches!(
|
||||
&error,
|
||||
DatabaseError::ForeignKeyViolation {
|
||||
constraint: Constraint::RecurringTransactionSourceAccount
|
||||
| Constraint::RecurringTransactionDestinationAccount,
|
||||
..
|
||||
}
|
||||
);
|
||||
|
||||
if is_recurring_transaction_reference {
|
||||
RepositoryError::ReferenceViolation {
|
||||
relation: ReferenceRelation::RecurringTransaction,
|
||||
kind: ReferenceViolationKind::StillReferenced,
|
||||
source: error,
|
||||
}
|
||||
} else {
|
||||
RepositoryError::Database(error)
|
||||
}
|
||||
}
|
||||
|
||||
fn decode(row: AccountRow) -> Result<Account, DecodeError> {
|
||||
@@ -132,6 +157,39 @@ mod tests {
|
||||
|
||||
use super::*;
|
||||
|
||||
fn foreign_key_violation(constraint: Constraint) -> DatabaseError {
|
||||
DatabaseError::ForeignKeyViolation {
|
||||
constraint,
|
||||
source: sqlx::Error::Protocol("test database cause".to_owned()),
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn classifies_account_delete_foreign_key_constraint() {
|
||||
let error = classify_delete_error(foreign_key_violation(
|
||||
Constraint::RecurringTransactionSourceAccount,
|
||||
));
|
||||
assert!(matches!(
|
||||
&error,
|
||||
RepositoryError::ReferenceViolation {
|
||||
relation: ReferenceRelation::RecurringTransaction,
|
||||
kind: ReferenceViolationKind::StillReferenced,
|
||||
..
|
||||
}
|
||||
));
|
||||
|
||||
let database_error = std::error::Error::source(&error).unwrap();
|
||||
let sqlx_error = std::error::Error::source(database_error).unwrap();
|
||||
assert!(sqlx_error.to_string().contains("test database cause"));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn keeps_unknown_account_delete_foreign_keys_generic() {
|
||||
let error = classify_delete_error(foreign_key_violation(Constraint::Unknown(None)));
|
||||
|
||||
assert!(matches!(error, RepositoryError::Database(_)));
|
||||
}
|
||||
|
||||
fn row() -> AccountRow {
|
||||
AccountRow {
|
||||
id: Uuid::new_v4(),
|
||||
|
||||
Reference in New Issue
Block a user