Implemented a domain layer, because the API DTO's where getting bloated.

This commit is contained in:
2026-09-26 17:22:10 +02:00
parent 04debfba7b
commit 4737bd5c81
24 changed files with 1103 additions and 538 deletions
+52 -45
View File
@@ -2,11 +2,7 @@ use chrono::{DateTime, Utc};
use serde::{Deserialize, Serialize};
use uuid::Uuid;
use crate::database::dtos::transaction::TransactionRow;
use crate::routes::dtos::{
cents::{Cents, CentsConversionError},
direction::{Direction, DirectionConversionError},
};
use crate::{domain, routes::dtos::direction::Direction};
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct Transaction {
@@ -19,80 +15,91 @@ pub struct Transaction {
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct TransactionData {
pub description: String,
pub amount_cents: Cents,
pub amount_cents: u64,
pub direction: Direction,
pub date: DateTime<Utc>,
}
impl TryFrom<TransactionRow> for Transaction {
type Error = TransactionConversionError;
fn try_from(row: TransactionRow) -> Result<Self, Self::Error> {
Ok(Self {
id: row.id,
impl From<domain::Transaction> for Transaction {
fn from(transaction: domain::Transaction) -> Self {
Self {
id: transaction.id,
data: TransactionData {
description: row.description,
amount_cents: Cents::try_from(row.amount_cents)?,
direction: Direction::try_from(row.direction)
.map_err(TransactionConversionError::Direction)?,
date: row.date,
description: transaction.description,
amount_cents: transaction.amount.get(),
direction: transaction.direction.into(),
date: transaction.date,
},
})
}
}
}
#[derive(Debug, thiserror::Error)]
pub enum TransactionConversionError {
#[error(transparent)]
Cents(#[from] CentsConversionError),
#[error(transparent)]
Direction(#[from] DirectionConversionError),
impl TransactionData {
pub fn into_domain(self, id: Uuid) -> Result<domain::Transaction, domain::ValidationError> {
Ok(domain::Transaction {
id,
description: self.description,
amount: domain::Cents::try_from(self.amount_cents)?,
direction: self.direction.into(),
date: self.date,
})
}
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn preserves_cents_in_response() {
let id = Uuid::new_v4();
let date = Utc::now();
let response = Transaction::try_from(TransactionRow {
id,
fn data(amount_cents: u64) -> TransactionData {
TransactionData {
description: "Groceries".to_string(),
amount_cents: 4250,
direction: "out".to_string(),
date,
});
amount_cents,
direction: Direction::Out,
date: Utc::now(),
}
}
let response = response.expect("valid direction");
#[test]
fn converts_between_dto_and_domain() {
let id = Uuid::new_v4();
let transaction = data(4250).into_domain(id).unwrap();
assert_eq!(transaction.id, id);
assert_eq!(transaction.amount.get(), 4250);
assert_eq!(transaction.direction, domain::Direction::Out);
let response = Transaction::from(transaction);
assert_eq!(response.id, id);
assert_eq!(response.data.description, "Groceries");
assert_eq!(response.data.amount_cents.get(), 4250);
assert_eq!(response.data.date, date);
assert_eq!(response.data.amount_cents, 4250);
}
#[test]
fn rejects_amounts_that_do_not_fit_in_database() {
let error = data(i64::MAX as u64 + 1)
.into_domain(Uuid::nil())
.unwrap_err();
assert!(matches!(
error,
domain::ValidationError::Amount(domain::CentsConversionError(value))
if value == i64::MAX as i128 + 1
));
}
#[test]
fn keeps_transaction_json_flat() {
let response = Transaction {
id: Uuid::nil(),
data: TransactionData {
description: "Groceries".to_string(),
amount_cents: 4250.into(),
direction: Direction::Out,
date: Utc::now(),
},
data: data(4250),
};
let response = serde_json::to_value(response).unwrap();
assert_eq!(response["id"], Uuid::nil().to_string());
assert_eq!(response["amount_cents"], 4250);
assert_eq!(response["direction"], "out");
assert!(response.get("data").is_none());
let request: TransactionData = serde_json::from_value(response).unwrap();
assert_eq!(request.description, "Groceries");
assert_eq!(request.amount_cents.get(), 4250);
assert_eq!(request.amount_cents, 4250);
}
}